|
|
|
|
|
|
by napo
1318 days ago
|
|
|
Asking for code to be reviewed within one day worked well in the teams I worked with.
Some pple likes to do it in the morning before starting the rest of their day. And if someone has something urgent or small they can always ping the team. I can understand than for changes in a language it's a bit more involved than that though. Also, I'm really curious about teams that do reviews after merge. I heard some places do it but I never really got a good understanding of the pros&cons |
|
|
I can imagine it works for larger features that need a more thorough, formal review. I'm personally only familiar with code reviews on smaller changes (from trivial fixes to whole features, but often limited to <1000 LOC). The danger of only reviewing small parts of a larger whole is that you miss things in the larger whole.
But for that, you can do both; small code reviews from a 'task' branch into a 'feature' branch, then a big code review before merging into the main branch. The smaller reviews should catch the more trival or obvious issues.