Hacker News new | ask | show | jobs
by JimDabell 1335 days ago
> My team posts their PR reviews in our team slack channel. Which bothers the totally async purist in me, but we’ve found it to be a good middle ground between waiting for reviews requested via GitHub email and actually pinging someone.

Why don’t you install the GitHub Slack application? It will tell you immediately when somebody asks for a review and it has other useful functionality as well.
1 comments
jlund-molfese 1334 days ago
Oh, I guess some additional context is that by convention we use Slack emoji to indicate whether we approve, comment or request changes. Then again when it’s merged/deployed. Reviews aren’t specifically requested of individuals, usually just the entire team. That way, if it’s a channel everyone is in, other people can see at a glance whether they should still review the PR.
link
savy91 1334 days ago
The github slack integration would post a message in a slack channel and then your team can use emojis to react to it just like you do.
link
jlund-molfese 1334 days ago
Will have to check that out then, thanks!
link