Hacker News new | ask | show | jobs
by kwkelly 1346 days ago
I work that way. I generally constrain my changes to a single package, module or layer of the application at a time. The feature won't work end-to-end until after several PRs are merged. Sometimes it can take 15+ PRs, but it's a lot easier for reviewers if the changes are small and limited in scope and functionality.
1 comments

You’re comfortable trading your time (increased number of diffs) for increased level of sanity checking from reviewers.

In my experience, that means days of increased effort - async reviews, more explanation needed for people who are unfamiliar with the code, an additional coordination layer of explaining where we are and where we’re going, increased probability of bike shedding, and waiting for your turn to get into CI.

Not saying you shouldn’t make that trade-off: if you feel you should, you probably should. But we need to be clear about the trade offs, to better understand when that makes sense.