Hacker News new | ask | show | jobs
by lambdafourtwo 1364 days ago
OP must've got a PR about this blocking him from merging.

It's having me think about the way prs should be done on divisive topics.

On one hand you have this "guy" who thinks he's gods gift to programming demanding a new line be added to all 30 files you're adding to the project.

On the other hand that "guy" is you.

What then? In both cases.
1 comments
Nextgrid 1364 days ago
"What" to do matters less than consistency (in most cases - if you have technical reasons to pick one or the other, do so). Use a linter that can auto-fix everything and enforce that.
link
lambdafourtwo 1362 days ago
Consistency is an ocd thing.

Being consistent is orthogonal to readability and modularity and extensibility.

It's actually delusional. Most programmers want to be consistent based simply off a feeling but in actuality the benefit of consistency is minimal.

You "are" that guy.

link
Nextgrid 1361 days ago
The benefit of consistency in this case would be that your git diffs aren't littered with irrelevant changes because someone prefers one convention and someone else prefers the other.

Which convention is chosen as the default doesn't usually matter (unless some of the edge-cases raised by the other comments are relevant to you), but what matters is what when you look at a diff it isn't polluted.

link
lambdafourtwo 1361 days ago
> The benefit of consistency in this case would be that your git diffs aren't littered with irrelevant changes because someone prefers one convention and someone else prefers the other.

If you didn't care about consistency you wouldn't be changing others people code to be consistent.

You would make your own change and that relevant change remains inconsistent. That's it.

>Which convention is chosen as the default doesn't usually matter (unless some of the edge-cases raised by the other comments are relevant to you), but what matters is what when you look at a diff it isn't polluted.

Again the diff isn't polluted. It is simply inconsistent. This is different from two people battling over which convention to follow (which is what you are referring to). In the later case, yes you will see diffs where one person attempts to change the convention, in the former case you simply see a diff where the change doesn't follow a convention.

link