Hacker News new | ask | show | jobs
by peterkelly 1419 days ago
Ah, thanks for the clarification.

This was definitely not obvious to me from their announcement and I wouldn't be surprised if others similarly misinterpret it.
1 comments
politelemon 1419 days ago
It was very obvious to me, it's right at the top of the page.

> Note: This change does not impact regular review comments or other comments made directly on a pull request.

link
rpdillon 1419 days ago
I had the same confusion as gp and spent a couple of minutes resesrching to figure it out. The reason the above quote didn't help me is that is clarifies that this isn't about review comments or other PR comments. But commit messages are neither of those.

Root cause? I didn't even know commit comments were a thing that GitHub had! I assume it was much clearer to everyone that knew about them.

link
peterkelly 1418 days ago
> Root cause? I didn't even know commit comments were a thing that GitHub had!

Me too. It wasn't a term or feature I was familiar with, and (incorrectly) assumed they were talking about commit messages.

link