Hacker News new | ask | show | jobs
by rmk 1408 days ago
I just moved to a job with no pull request reviews, and I'm enjoying it. The flip side is that it's very easy to have a major screw up that can mess things up big time, but there are tests and such which prevent major disasters. Further, one can do 'cleanups' every once in a while to reduce tech debt.

A lot of places where there are insane PR reviews are where management has abdicated its responsibility to oversee code quality; essentially, it is poor leadership, where management is either too apathetic, swamped with unnecessary meetings, or just lacking in technical direction with too many changes in direction.

It's almost always hard when you first start up at a place and get used to its standards when you merge your PRs the first few times, but if it is a recurring problem, then you are not at fault: the organization is fucked up.

1 comments

Same. I didn't mind someone reviewing my code, but I sure as hell hated having to give one more than once or twice a week. At "end of sprint" I'd be besieged with requests for reviews. I'm talking like 5 or 6 in a day. It was annoying as hell. I complained about it, nothing was done, so I left.