| It’s especially difficult when they came up with it themselves. We’re amidst a rewrite and we have an off-shore team involved. They same team that built the original starting 4yrs ago. One of their team members decides “we should validate the TLD for email addresses entered by the user.” Code is added, a TLD file is added, and in code review I reject the whole concept. Show me the ticket or feature docs, and I’ll argue with the author of those instead. “We did this in the last app…” Maybe, but we didn’t spec that for this app. He got his local project lead (non-tech) to write a Jira story for us to “discuss the technical implementation.” Dude, srsly. Our app is web-first and is used on congested mobile networks (like, hundreds of people all using the same cellular site simultaneously.) A TLD file does not need to be delivered to each of them for validation that’s pointless. The idea is off the table, code rejected, but the guy spent time doing something no one asked for and had his local team onboard with it. |