|
|
|
|
|
by jdlshore
1442 days ago
|
|
It's probably too late to make a difference to your vacation, but it sounds like these folks need active coaching. Rather than doing your PRs asynchronously, have you considered sitting down with one or both of them to do the PR review? Pull the code up in your editor and refactor as you go (and teach them how to refactor). Get the code to a good state and commit/approve it right there. As for your vacation, I agree with the commenter who suggested having them pair while you're gone. In fact, pairing or mobbing might be just what this team needs. You'll be a much more effective coach if you work with them directly rather than "seagulling" [1] PRs. [1] Seagull coaching: Fly in, shit all over everything, fly out. |
|