Hacker News new | ask | show | jobs
by eloff 1449 days ago
Exactly this. I fixed a problem like this a week ago. I found some duplicated code, factored it out into one place by introducing an abstract base class (Python) and in the process discovered one of the duplicated methods had a logic error leading to returning a slightly smaller integer result.

The code had test coverage, but the test confirmed that it produced the wrong result. I had to fix the test too.

1 comments

So your refactor broke the tests, so you assumed the tests must be wrong.
So his refactor fixed a bug and broke a test which he fixed, so you assume he must have assumed instead of verified.