[bstpierre]

Not a knock against crocodile, which looks like a nice set of improvements over gh, but something I’d like to see done better in any code review system is significantly better code navigation.

For any PR that is nontrivial I will pull it locally so that I can more easily navigate to functions/data types that are used by or changed in the PR. It would be nice if the review ui provided a way to click through to the definition of a symbol that appears in the code. (I think gh does this when browsing code for some languages.)

A related helpful feature would be the ability to see “what calls this”. Currently I have to do this kind of review with ‘git grep’, after pulling locally.

I’d also love to be able to toggle into ‘git blame’ for a given bit of code, in order to better understand why the code is in its current state

[dsmmcken]

Hitting the keyboard shortcut "." on a PR in GitHub to open it in a vs code web view is pretty great, and I find it a substantial improvement to the normal GitHub PR workflow, especially with large PRs. You can also install the GitHub PR extension in vs code to get the same experience locally, along with gitlens to get a nice inline blame.

[darkerside]

You're basically asking for an IDE to be part of your code review tool, which I don't think is a bad idea

[jlkuester7]

Yeah, IDEA already basically supports this concept: https://blog.jetbrains.com/idea/2018/10/intellij-idea-2018-3...

[user3939382]

ctags allows this and isn’t necessarily part of an IDE. Granted, that may be where most people encounter this feature.