[lhecker]

I'm not sure editing the article would be the proper thing to do at this point. Someone else suggested to edit in 1-2 weeks for possible future readers.

I can add back the sentence where I accredit Alacritty for the general, underlying algorithm/idea then, because that's where I heard about it first. There isn't really any other alternative, performant way to implement GPU-accelerated terminals, so I don't think hearing about it again from Casey changed my perception of what the only alternative to Direct2D is, in case it's fundamentally flawed for our purpose which it turned out to be.

[phendrenad2]

Sometimes logic isn't enough. YOU caused a huge amount of anger among the community by being condescending, and insisting "I learned this from alacritty, not the person I was condescending towards" isn't going to make anyone less angry. I'm just telling it like it is here. Humility is, unfortunately, what you need, and you can't fake humility.

[dmitriid]

> I'm not sure editing the article would be the proper thing to do at this point. Someone else suggested to edit in 1-2 weeks for possible future readers.

There's nothing improper with adding "Edit: credit to the <name of the person> who suggested the solution. While the solution seems trivial, there are certain technical challenges to overcome".

> because that's where I heard about it first.

No. That's not where you heard it first. Otherwise you wouldn't have written "this needs doctoral research on performance" in the original issue.

Edit: I misattributed this quote, you didn't say it.

> I don't think hearing about it again from Casey

There's an actual, verifiable screenshot of your reaction to his words. That was not an "again".

[zamadatix]

> There's nothing improper with adding

The point of the waiting to edit suggestion is to avoid a bunch of reactionary edits during the most heated period. Immediately implementing every edit demanded of you when different people are demanding different edits all at once seems improper to me and waiting a short period seems a level headed approach. It also avoids the look of just trying to cover everything up the quickest way possible instead focusing on well thought out sincere reactions.

> No. That's not where you heard it first. Otherwise you wouldn't have written "this needs doctoral research on performance" in the original issue.

You've attributed the quote to the wrong person, it was not lhecker who said that.

> There's an actual, verifiable screenshot of your reaction to his words. That was not an "again".

There is nothing in lhecker's response that suggests he hadn't heard of the alternative. His comment argued it should all be able to handled in DirectWrite without using the alternative not that the alternative hadn't been thought of.

[dmitriid]

> You've attributed the quote to the wrong person, it was not lhecker who said that.

Ah, true. I definitely misattributed this statement. For this I apologize.

> His comment argued it should all be able to handled in DirectWrite without using the alternative not that the alternative hadn't been thought of.

His statement was "it isn't worth it" and "we ready doing it via the framework we're using" to only state, a year later, [1] "We actually took the same approach Casey suggested" while insisting that "it doesn't help much".

If he'd heard about this approach before and seen it in, say, Alacritty, he has a very shitty way of showing it.

[1] https://news.ycombinator.com/item?id=31285723

[zamadatix]

I'm not sure I'm much of one for being able to untangle interpretations of chunks taken from comments spread over literal years but I think the distinction missing here is previously the WT team thought they could get away with using DirectWrite's built in approach to handle the precise issue. It was never that they didn't know there was an alternative to DirectWrite just they thought DirectWrite had a way to do it that would work just as well. They then found out this wasn't the case, completely backpedaled on which was the right architectural way to achieve the goals, and wrote this blog post about having implemented it the other way. This is what the full blogpost tries to detail the history of.

It might be a good olive branch to extend thanks to cmuratori for trying to push that it was the right architectural choice but it was never about being the source of the idea. In either case it probably is a good idea to credit the other terminals that had already proven the implementation can work prior to all of this even starting though.

[dmitriid]

I totally agree with you

[TrueTom]

https://www.youtube.com/watch?v=nDO24U3hMkU

(it's bit long-winded but the general message is sound)