|
|
|
|
|
by alexk
1547 days ago
|
|
That's a fair question. The team votes on specific aspects of implementation that can not be verified by running a program, for example: * Error handling and code structure - whether the code processes errors well and has a clear and modular structure or crashes on invalid inputs, or the code works, but is all in one function. * Communication - whether all PR comments have been acknowledged during the code review process and fixed. Others, like whether the code uses good setup of HTTPS and has authn are more clear. However, you have a good point. I will chat to the team and see if we can reduce the amount of things that are subject to personal interpretation and see if we can replace them with auto checks going forward. |
|
A rubric written in advance that would allow a single person to vet a work sample response mostly cures the problem you have right now. The red flag is the vote.