|
|
|
|
|
|
by jjav
1553 days ago
|
|
|
> GitHub's Pull Request feature creates an expectation that the maintainers will read a contributor's code > Back in the days of SourceForge... Strongly agree. The github PR is a somewhat toxic misfeature. The last thing I want in my open source projects is some rando sending some huge diff that does who knows what. Now I'm supposed to read and understand this code and figure out all the unintended side effects? And even if the code is ok it's probably missing test coverage, doc updates, etc. So filling the gaps would generate more work for me. However, I do like and accept tiny PRs that fix very targeted things. I wish I could put a size limit on PR diffs in github. Something like if the PR changes more than 10 lines of code, block it. File a ticket instead of discuss the proposal, don't blast me with code I don't have time to read. |
|
|