|
|
|
|
|
|
by abstract_put
1557 days ago
|
|
|
I think whether it's acceptable or not is heavily dependent on the team and the work. In my personal experience (mostly Java) when people say they can't reasonably split something up it's more often a "not willing to" than "actually can't". Generally speaking the strategies that make smaller code reviews possible also have a whole bunch of positive side benefits, a la "make the change easy, then make the easy change". I personally save many-hundred-line reviews for 100% automated refactorings or string find/replace or similar, though I acknowledge I'm often doing extra work just to make the PR process smoother (even if it's a throwaway intermediate step). |
|
|