|
|
|
|
|
|
by muzani
1572 days ago
|
|
|
In most of the situations where the code doesn't run, the person creating the PR didn't commit the code needed to make it run, but have it offline. I've bitched at someone who approved a PR in about about 10 minutes, but there was a merge conflict where the ">>>>>>>" would have been apparent for anyone who actually even glanced at the code. I'd say much of the value of a code review on senior devs is making sure that it's just all properly committed and nothing breaking. |
|
|