Hacker News new | ask | show | jobs
by c7DJTLrn 1572 days ago
No.

  1. PRs should target development, which is an *unstable* branch, so no biggie if something breaks
  2. CI should catch things like syntax errors, failing tests, or poor test coverage
  3. I trust my colleagues to do their work properly and fix things if they've made a mistake
1 comments
wodenokoto 1572 days ago
I don’t get your first point. If the pull request doesn’t run:

- how can we even say it works?

- who’s responsibility is it to fix it?

- and when does it get fixed?

link
c7DJTLrn 1572 days ago
What do you mean "doesn't run"? Tests should catch the most obvious/common bugs. If you mean it doesn't compile, then something is wrong because why would any engineer check in code that doesn't compile unless they're distracted or under pressure? And again, this would be caught by CI.
link
striking 1572 days ago
In order:

* Tests

* The engineer making the PR

* Before they're allowed to merge

link