[NicolaiS]

Satoshi was maybe an above-average coder nor cryptographer, but not genius. Reminder: bitcoin v0.1 was made to run only on Windows, the code was fairly ugly and had a bunch of common crypto mistakes/weirdness [0].

Don't get me wrong, Satoshi was/is a genius, but not for his coding/cryptography skills.

[0] A good summary of vulns in bitcoind: https://en.bitcoin.it/wiki/Common_Vulnerabilities_and_Exposu...

[nullc]

Most of those vulnerabilities were added later, the original bitcoin software had an extraordinarily low defect rate. While some of the bugs in the original were very severe indeed (particularly in Bitcoin script), there were very few in total.

The original code was essentially perfectly portable and extremely clean. It's true that it was was highly integrated, and lacked significant modularity-- but this also made it small and simple. Its use of modern techniques and conscious style made it completely free of broad classes of bugs.

The more modern code is highly abstracted and modular, but much more difficult to read, understand, and review. But its level of functionality wouldn't be realistic or maintainable (particularly by such a large number of participants) otherwise. That level of functionality didn't exist in the original code.

The ugly comment is the sort of remark made by junior developers who can't distinguish style different from what they learned from poor quality. Poor quality code also differs from their preferred style, but not everything that does is poor quality. By any objective metric, -- save modularity/abstraction-- the original code base was extremely high quality including the metrics that matter most: the defect rate. The level of abstraction wasn't optimum for the work that came latter, but it wasn't later and prematurely abstracting would have made the code far less clear (and probably less reliable).

[RL_Quine]

The "the code was ugly" thing is an often repeated statement but doesn't really reflect the reality of what was released.

The source code is very tightly integrated, but it avoids many of the common issues you would see in software of its type (ie, the wire protocol had no variable length strings whatsoever), and it implements a crazy amount of different features in a concise, readable code base. You can look over the original Bitcoin source code and immediately get an answer for how something functions, which is entirely the goal for what was effectively a prototype that introduced new key concepts to anybody who picked it up. wxBitcoin compiled happy on linux with only minor modifications, and OSX not a whole lot of time afterwards.

If the author had gone for absolute perfection or many levels of abstraction it never would have been released; what was created was nothing short of astounding, and being functional while creating something so absolutely novel is great code.

[adastra22]

> the wire protocol had no variable length strings whatsoever

Script is serialized as a variable-length string.

[RL_Quine]

It is variable length but not a string.