Hacker News new | ask | show | jobs
by hinkley 1604 days ago
Current team has very low code review participation, and I have a few fights I’m putting most of my energy into so I have to let other things go.

But when I was in your shoes, I figured out that some other people would make the same comments I would if they saw them first. The simplest thing to do was to wait or poke them to review the code, then mop up anything they missed. Or I could gamble that they would eventually review it and leave empty space for them to fill.

I think it’s not unlike what the smart kids learn in school: you might know the answer before the question is even out of the teacher’s mouth, but give everybody else in the class a chance before you put your hand up. What’s important is that everyone learn the answer, (and to keep the flow of the lesson, that the question gets answered) not that the answer comes from you.

You can also bury the lede by saying too much. If you complain about eight things how are they to know that #3 is the most problematic?