[pilif]

If I was in the position of having to review that PR, I would probably flat-out reject it and ask for just the minimal changes required.

I don't see how adding an additional capture framework backend would require meaningful changes to the build system.

With some likelihood, in this case, Apple probably won't have the resources to rework their PR and thus the PR will stay un-merged until somebody of the project has time to merge/reimplement the relevant parts.

Which of course is a total shame and I wonder why Apple didn't have "mergeability" in mind when they decided to create their PR. They must have known that "rework the build system" can't be part of a PR adding a capture backend if they wanted any chance of this being merged.

[madmoose]

The Apple developer's commit builds upon another pull request which contains the build system work by OBS developers, the build system changes are not part of Apple's commit.

[kristjansson]

A million comments and this is the only valuable one. Amazing that everyone accepted the premise that Apple proposed refactoring some other project’s CI.

[Diskutant]

No, the PR is based on another PR [0] which adds Apple Silicon and Universal Binary builds, the mentioned commit is part of that PR.

[0] https://github.com/obsproject/obs-studio/pull/5155/commits

[pbhjpbhj]

>Apple probably won't have the resources to rework their PR //

Aren't Apple the richest corporation in the World, how would they not have resources; am I missing a joke? Maybe you meant 'will choose not to'?

[Cullinet]

I didn't get where I am today by employing engineers with my profits...

Before three was Dallas, there was The Rise And Fall Of Reginald Perrin, in the main arc a dark parody of 70s corporate England. If you could find a better audio-visual exposition of the transatlantic difference at the end of the nineteen seventies, you will struggle to find a funnier one.

http://www.leonardrossiter.com/reginaldperrin/CJisms.html

https://www.google.co.uk/search?q=reggie+perrin+i+didn%27t+g...

[spockz]

It is not that uncommon to have make changes to a build system in many places in order to support a new architecture. Especially if there was previously only support for a single one.