Yeah well except that that's not even related to what's happening here. Good thing though that you spotted it immediately and that you're smarter than all the developers you encounter ^_^
Well, when working on a code base, the first thing I think is who wrote this and when. When they wrote this how experienced was the developer? What's there coding style or was it written after coding standards were introduced? I've had this misfortune of inheriting a lot of bad legacy code in the past and when you see a chunk of bad code, you can either spend a good chunk of time figuring what it's really doing or less time figuring out the intent. Depending on who wrote the code, what it does, and various other factors you can decide which path to take.
With this code snippet it's obvious that the intent is to remove all the elements. So it can be fixed with a .Clear();
From a higher level, you can see that the snippet smells bad, and will need some attention.
I didn't say I'm smarter than all the developers I encounter. I've just encountered a lot of bad developers in my time.
With this code snippet it's obvious that the intent is to remove all the elements. So it can be fixed with a .Clear();
From a higher level, you can see that the snippet smells bad, and will need some attention.
I didn't say I'm smarter than all the developers I encounter. I've just encountered a lot of bad developers in my time.