[MattGaiser]

> but there's always some common basis that everyone agrees on.

I am really curious what this is because I have been with 4 organizations now and despite all doing things very differently, they insist that they are doing things according to "industry standard."

I have even had a few cases of two senior devs reviewing my PR at the same time and going back and forth to tell me to revert what the other dev had me put in, with both coming from prestigious companies.

[no-s]

>> had a few cases of two senior devs reviewing my PR at the same time and going back and forth to tell me to revert what the other dev had me put in

As a senior guy reviewing code I’ve asked for reversion of stuff i made the dev put in. On more than one occasion. Nobody’s perfect.

I admit that after a few cases of that I realized I needed to rethink code reviews and became more mindful of distinguishing between things that really needed to change, things needing explanation, and things inspiring overzealous pedantry. Made code reviews much less time consuming.

[hamedb]

for the "common basis" part I'm referring to commenting code/ using descriptive variable names/ breaking mega large files into smaller ones...

things that developer do not agree on include choosing between (object-oriented, procedural or functional code)

the debate of isolating small bits of code regardless of the paradigm used. how many "code components" can be created without making the follow references game so crazy that you can't even understand the code flow and where you even started reading the code. are small code duplicates really that bad or over componentizing is a bigger issue that tries to solve the first one?

things like that...

I didn't work for large company before so was wondering if you saw any consensus/ agreement patterns between senior developers in these type of debatable things especially when writing JS because of it's huge flexibility.