Hacker News new | ask | show | jobs
by scrame 1636 days ago
m_hasBrokenEncryptedMediaAPISupportQuirk = domain == "starz.com" || domain.endsWith(".starz.com") || domain == "youtube.com" || domain.endsWith(".youtube.com") || domain == "hulu.com" || domain.endsWith("hulu.com");

Wow I thought you were kidding.
1 comments
cookiengineer 1636 days ago
It gets worse if you search for "microsoft.com" [1] or "bbc.co.uk" in the codebase. They literally grant cross domain storage access because Microsoft's login workflow is broken in regards to CORS headers.

I mean, imagine a developer trying to fix their code behaving completely different on iOS and they cannot have a single clue why that is the case.

Additionally, WebKit is released very late to the public (sometimes even after fixes have been rolled out to iOS)...and before that nobody from the outside can even know what's going on.

From a maintainability point of view things like this should be - in worst case - a Web Extension, but definitely not be inside a Browser source codebase.

Youtube is even worse once you dig through the Apple internal plugin replacement, which effectively implements a native C++ decoder for youtube streams on iOS because otherwise you could not watch videos there. This was done before as a WebCore plugin but has been moved around into the PluginProcess source-code wise over the last two months (and currently blocks me from merging in changes, so I have to backport fixes after I removed all legacy plugin APIs).

[1] https://github.com/WebKit/WebKit/search?q=microsoft.com

link