Hacker News new | ask | show | jobs
by Osiris 1643 days ago
I often approve a PR with the comment "Approved with comments".

In other words, I didn't notice any bugs but I have some suggestions. I'll let you decide if you want to make the changes or not.

2 comments

+1. The job of reviewer on shared codebases is advisory, not as a gatekeeper.

If people choose to ignore comments, then that's a behavioral issue worth escalating.

I've been in teams where those comments are never addressed because the pressure is on "push something that roughly solves the task so you can show something during demo".