[ciarlill]

I think it's worth noting this is largely an implementation on top of the Mediasoup SFU project. MiroTalk is not really the SFU here. It's just a client and server side API built on top of an existing open source SFU. And they don't appear to mention this or credit Mediasoup for this anywhere. It's a cool project, very useful and appears to be in full compliance with mediasoup licensing... but it still feels a little disingenuous to label it as an SFU.

[mionhe]

Unless they've changed it in the last 45 minutes, the first line of the description says: "Powered by WebRTC and SFU integrated server." and "SFU" is a link to the Mediasoup website.

[ciarlill]

I guess that's fair. I missed the 3 letter hyperlink in the Github README. Would be nice if some credit was given on https://sfu.mirotalk.org/ Normally I would not be so pedantic about the use of a library, but mediasoup is doing the vast majority of the heavy lifting that makes this possible.

Edit: I see the mediasoup project is also listed by name in the credits section. So I rescind my earlier comment. I still think it's a fine line to call this project itself an SFU though.

[mp85]

Hello mionhe welcome, that you mentioned It has been there since the first commit (103 days ago) :)

[mp85]

Hi ciarlill, thanks for saying it's a Cool project :) credits are always due, if you look at the references cited there are from the first commit. All the best