|
|
|
|
|
by nacho_weekend
1682 days ago
|
|
Blindly checking out code late at night, without PR review, without discussion about context, overwriting approved and (I assume) tested changes, for code you did not write and were not included on review for, BLINDLY merging to master (!?) - this could be tantamount to a fire able offense depending on where you work. I would have a hard, long talk with any of my mid or junior engineers if this was attempted (although master should ideally be protected, preventing this scenario unless OP had administrative senior permissions on the code base). All around a mess. I agree with the sentiment (write clean code unless you shouldn’t) but there is some serious process issues here that should be caught and corrected and would have made this entire issue something during the PR review phase, where OP presumably asks for an improvement and is answered with the context for the decision. Not to mention the red flag of “I know better than my peers” attitude of many programmers I have known in the past, leading to distrust and backstabbing. It can get ugly. |
|