Hacker News new | ask | show | jobs
by omegalulw 1683 days ago
> I have to disagree with this as it relies on the assumption that every commit on a branch is logical and descriptive. In my experience a lot of PRs will have small commits that have poor names as they go through a review process.

There's your problem. Code reviews should not allow such commits to pass through.

1 comments

> Code reviews should not allow such commits to pass through.

Are you suggesting that your code review process has a stage for combing through commit messages? What does this look like? If the third commit message of 15 isn't up to par what happens?

You ask them to fix the commit message. Every git GUI should support that by now, so it should be a 1 minute fix, even for junior devs.