Hacker News new | ask | show | jobs
by Narann 1709 days ago
Direct for sure, but not rude.

Someone want a modification to be merged and push a lot of template code giving a 3 line PR explanation.

This kind of situation comes often in OSS, specially in C++ project and I wouldn't be surprised if OMW had a lot of PR like this.

With this kind of PR, the maintainer have to go into each line and try to understand what the point because the original author didn't explain that much + it's C++ template and not everyone like that.

This is not a excuse to be arsh or anything, another option would have been to put a tag "need clarification" and let the PR in a hole and force the author to motivates its modifications.

1 comments

Not just a simple template, a template template, which is certainly quite obscure.