Hacker News new | ask | show | jobs
by squabble 1717 days ago
Why do they put many unrelated things in the same bill? Smaller, independent pull requests seems like a better way.
1 comments

Actual answer: Because the code management system is built with certain merge restrictions:

- A PR can be merged with 50 or more code reviews and approvals if it has 0 rejections

- If there are any rejections, the requirement is a little more intense, at 60 or more code reviews and approvals

- Once per year, one PR can be merged per year with 50 code-review approvals and any number of rejections.

- The company has 100 developers and at least 41 will reject every single PR summited for review

- It takes agreement of 50 developers to change the merge rules, and there are 48 or fewer who want to do so

This is why there are so many unrelated changes in one PR. It's probably the only one they will be able to merge this year.

Other than the once per year point, these all seem like reasons to make smaller PR's.