|
|
|
|
|
by jeppester
1724 days ago
|
|
I don't feel very convinced by the case you are trying to make here. You did not mention colorette until you were forced to do it. Why not talk to the author before making a fork? You mention that you disagreed with changes in colorette, but you have no evidence for it. If you discussed it in an issue or PR, that would be easy to find and share. You took all of colorette.
The "backported" performance improvement is a single line of code. That you try to make it seem like exactly the same thing seems childish and bullish to me. If you are really not acting in bad faith, why not drop your fork now that colorette has changed the API back? |
|
First mention (it was changed later) was added 6 days ago (threat was created 2 days ago): https://www.npmjs.com/package/nanocolors/v/0.1.2
Webpack team ask Colorette’s author to rollback API 2.x changes here (discussion was cleaned by Colorette’s author, but he said that it is how it see the best API): https://github.com/jorgebucaran/colorette/issues/70
> why not drop your fork now that colorette has changed the API back?
Author continued to act impulsively. He rolled back API in patch release instead of major made breaking changes.