Hacker News new | ask | show | jobs
by monster_group 1734 days ago
Just to be clear - I am strongly in favor of code reviews and do them every day. However, the article advocates spending 20-40% time on doing code reviews. Good luck convincing your manager why your productivity is so low when others are churning out high quality features (because you spent 20-40% of your time reviewing others' code but they didn't spend commensurate time reviewing yours). Net result - other people's code is higher quality, they get more done. Your code is lower quality and you get less done. Good luck getting that promotion or even retaining your job.
2 comments

In those environments i'd expect a tech lead to take the initiative to stand up and explain / defend the team's quality control processes.

If the management rebukes, you move employer.

Quality is not something the customer or your manager is responsible for. It's entirely on us as professional developers.

That said - code review is not the only way to ensure quality. Do what works. Pairing generally works even better for getting quality review time in.

These things obviously are to a degree a matter of team-level process and policy. In other teams it might very well be "good luck getting that promotion if you constantly refuse to participate properly in code reviews".