Hacker News new | ask | show | jobs
by myk9001 1741 days ago
> I think the author is projecting an opinion of "I don't want to do code reviews" so is justifying that opinion by outlining a process which allows him to bypass reviews in majority of cases.

I thought that too. The author seems to came up with the whole "Ship/ Show/ Ask" strategy so that it looks like their team actually follows a process instead of just plain skipping on doing code reviews.

While I can relate to their motivation to go without code reviews:

> Sometimes Pull Requests sit around and get stale, or we’re not sure what to work on while we wait for review...

> We also get tired of the number of Pull Requests we have to review, so we don't talk about the code anymore. We stop paying attention and we just click “Approve” or say “Looks good to me”.

These problems are very real and take time and effort to address. I just don't think opting out of reviews is a good way to solve them.

Well, the team I'm on accepts what the blog post calls a Show PR in a rare occasion when something has to be fixed right now. E.g., the prod is down kind of situation. We still go through a review but don't wait for approvals to merge and if there is any feedback we deal with it later.