I just switched to a Framework from a 2018 MacBook Pro. My take: the display is comparable, the keyboard is much better, and the trackpad is fine, but not as good as Apple's.
My experience with Mac keyboards is either with its magic keyboard for the iMac, or the mid-2012 Mac Book Pro which has a fantastic keyboard. I've touched newer MBPs, and I despise the low-profile keys.