|
|
|
|
|
by pgroves
1757 days ago
|
|
Looks really nice. The big blob of parameters in the kwargs looks pretty intimidating to get correct. Maybe consider a builder object for the config: https://en.wikipedia.org/wiki/Builder_pattern. It would probably be easier to document, too (document the setter methods of the Builder rather than try to explain the nested dict). Feel free to ignore me. |
|