|
|
|
|
|
by mytailorisrich
1768 days ago
|
|
My view, and I think a best practice, is that for bugs the fix should be in a single, dedicated commit, even is that's just one line. For features you may split into multiple commits if things are too big but then each commit should be self-contained and complete by splitting the feature in a number of smaller improvements. So really, commits are what they are based on the work at hand as long as they are kept to manageable sizes. I've seen code reviews for 1000+ lines all over the place. The author may know what they are doing but the reviewers are usually lost... |
|