[zakpatterson]

Thanks for that feedback, having source material links in the comments is definitely a good idea.

I've added an issue to track that based on your feedback:

https://github.com/ustaxes/UsTaxes/issues/458

And another issue about floating point:

https://github.com/ustaxes/UsTaxes/issues/457

I have doubts about the floating point issue just because all values on the tax forms are calculated using floats and then rounded to the nearest whole dollar. But if there's even a possibility that an intermediate calculation could flip a x.49 to a x.50 and change the rounding, then I agree we should switch to a library.

About the contributor guide, we just tried to write it to be as welcoming as possible to new contributors. With respect to "'ask in discord' for the actual content of the tax calculations", I'm just not sure what you mean. That document isn't really relevant to tax calculations. We will give the document another look though based on your feedback.

[le-mark]

I’m sorry but this discussion is startling. Currency calculations and accuracy are critical, why would anyone use this if there’s even a chance it gives incorrect results? Once you research the topic you’ll see why JavaScript based languages haven’t been used generally. There are solutions for currency math in js like dinero.js:

https://frontstuff.io/how-to-handle-monetary-values-in-javas...

[mdaniel]

> I'm just not sure what you mean. That document isn't really relevant to tax calculations

I guess that's true if the only kind of contribution one wishes is for React or docker or rust-lang fixes, but the issues list currently contains "schedule E" and "HSA 8889" which don't sound like React or "general purpose" software contributions: they sound like changes or contributions to the tax calculations

If someone on HN has a passion for fixing those items, which section of the contributing guide tells them how to code up "schedule E" in a way that is going to be accurate and have its PR accepted? Saying whether new contributions require an accompanying test, and the testing strategy, seem also just absolutely beyond critical to me for a tax calculation system

Maybe all of these are, in fact, covered in discord. I grant that I'm just not a "hop into chat" kind of person, because I find it chaotic, the search is usually oppressively terrible, and it means someone needs to be available at the same time that I have the question