| One question from a Junior Dev or any dev for that matter with multiple possible outcomes depending: Q: Hi <insert dev name here>, say, why are you asking in my review if the class I introduced is really necessary? Answer from the Paranoia Distroya. PD: (Without taking their eyes from the screen or their hands off the keyboard). What is exactly the reason for the class?
You: Refactor common functionality.
PD: Well, long pause while typing really fast, that common functionality may change.
You: May?
PD: (long pause) I'll take a another look....
You leave after an awkward silence, next day your check-in is reverted and a new check in from PD has the module updated and the comment in the
code review marked as resolved. Answer from Mr. Rogers. MR: See, base classes are like like a regular class but they are also special. They provide an added layer of encapsulation.
You: So....
MR: I tell you what, lets go to your desk and I'll help you work on the base class and update the code with something that is much
better, then we will update your review and having it all tied up before lunch.
You and Mr. Rogers sit with you and tells what to change while he proselytize on the amazing powers of some editor. You try not to sight. He approves
the review with a smiley emoji. Answer from My Friend From Across the World (over SMS). MFFAW: What review? Can you give me review no?
You: DFDDS-4322343
MFFAW: Code change, check co: 5234543
You: I see commit, what of it?
MFFAW: Library removed, NA.
You: What library?
MFFAW: brb
You don't hear back from MFFAW, during scrum you ask again what to do about the code review, MFFAW gets the story assigned and
the review is closed. The code is checked in. A week later MFFAW updates the code and the base class you added is gone. Take away: Ask questions; be ready to roll with the punches. |