Hacker News new | ask | show | jobs
by makoz 1826 days ago
If the code review is routine, the approval will be quick and straight forward. There's barely any friction in my experience. I'd like to believe I'm competent, doesn't mean I'm infallible.

You can dedicate time to onboarding, doesn't mean it's realistic that they're going to ramp up on all code areas during that time.

> I expect utility of code review by a newbie/newcomer to the project to hover slightly over zero. Perhaps it's best to dedicate some time to proper onboarding instead.

I disagree. If the commit isn't understandable to people, including junior engineers, I think it's problematic. I want to write code that is maintainable and not have to worry about deciphering my reasoning was for certain decisions down the line. If it's not clear to junior engineers, chances are it might not be clear to me, or someone else 3 years later.

Something that makes sense to me at the moment because I have context, might not be clear to others. Reviews are a great way to call that out.