|
|
|
|
|
by pulledrequest
1833 days ago
|
|
I'm in agreement that there is a lot of room for improvement in the processes around Code Reviews and so I'm very optimistic about your ability to deliver real value in this area... that said, I'm struggling to square this solution. My experience is that the challenge is the lack of time allocated to Code Reviews and _not_ a lack of visibility: GitHub and GitLab support assigning reviewers and notifications, and there are lots of reminder apps around. Where do you see the difference in a private message to someone that says "hey, can you check out this Pull Request?" and a Slack channel that automatically says "hey, can you check out this Pull Request?" I don't mean to be cynical because I do believe there is a problem to be addressed but I am struggling to see how a bunch of auto-updating Slack channels are going to address it. That said, I haven't worked in a team where it's normal to jump on a call to discuss a Pull Request and so maybe that's the fundamental difference that makes it not right for my workflow but does make it meaningful for others. |
|
> Where do you see the difference in a private message to someone that says "hey, can you check out this Pull Request?" and a Slack channel that automatically says "hey, can you check out this Pull Request?"
In case 1, you need to write in dm to your reviewers and ping them again if you did not receive any news. In the other case, Axolo will do it automatically and remind them about it. We believe it's easier to have specific channels because if you're requesting a review at the same time as your reviewer might, different conversations will happen in the same dm channel. And that's only regarding someone asking someone else for a review, there are other informations that have importance in your worklfow regarding pull requests (Github actions, comments & reviews)
Referring to the lack of time, we think that might be addressed in motivating engineers do more code reviews. We try to foster better practices with our "leaderboard" but we're still iterating to find the best answer.