Hacker News new | ask | show | jobs
by kuba-orlik 1843 days ago
What I really like about Phabricator as a review tool:

* keyboard shortcuts to navigate through the changes

* ability to add a comment to multiple lines of code

* ability to suggest changes inline

* comments are saved as I type them, so an accidental tab close saves my work

* comments are submitted in batches when I choose to, not one-by-one after saving each one. Its's sooo useful, because it often happens that I ask a question about some piece of code and upon further reading I find the answer, so I can delete the question before submitting all the comments and the author won't be bothered by it

If anyone knows of a feview tool with similiar set of features, please please let me know :)

When it comes to task management in Phab, I like how the tasks can be arranged in a dependency tree. We have our "todo" view set up so it only shows tasks without dependencies and sorted by prioroty, so the work on the project self-organizes

3 comments

I have to say I’m not all that into GH[1]. However, if the above is what you want from a review tool I think it meets most, if not all, of those requirements.

[1]I mainly am not a fan of the PR model, GH’s performance if often terrible, availability like a yo-yo, and the UI is not as good as it could be. I’m also not a fan of centralising a distributed tool with a load of vendor lock-in to boot. There are some odd things you can’t turn off (such as PRs) and the issue management is weak, so you have to use something over the top of it for project management such as ZenHub.

SourceHut is more up my street.

Yeah, I didn't mention self-hostability is a must.

SourceHut is terryfying to junior members

I think Gerrit does most/all of this, like kb shortcuts, saving drafts and posting comments in a batch.
Gitlab (as of 11.something) has lots of nice keyboard shortcuts including search projects, searching merges, searching particular files etc. Comments are saved as you type. You can submit a review ith all your comments in one go.

I have not tried multiline or inline comments or changes.

The main differentiator between self-hosted and enterprise seems to be w.r.t. auditing capabilities.