[eru]

You are missing opportunity costs.

All the resources that went into the moonlanding could have gone into something else. Eg could have stayed in private hands.

For a different example:

Yes, in the real world WW2 sort-of gave us computers. But IBM (and similar companies) would have invented electronic general purpose computers anyway, and probably sooner, if there hadn't been a war going on.