[naivebull]

I do code review on both Gitlab and Github and found the experience on Github more pleasant. Things that help:

- Keep the PR small, the code changes focused.

- The “viewed” checkbox per file. Tick it as the file is reviewed. If the file is changed later, it will expand as “Changed since last viewed”. If not, one less thing to check on next review iteration.

- Keep discussions off Github. There should be one comment per issue as the initializer as well as reminder. The long discussions goes into a Slack thread.

- The reviewer is the one to resolve the comment. This way, you can resolve them as in “tick them off” as done.

[soenkeliebau]

Thanks! That last one is probably the most important one as that mostly makes my comments "disappear" I think.. Regarding discussions on Slack, since our product is open source we would ideally like to keep discussions somewhere viewable and related to the code changes so that people can see what was discussed later on. It is a bit hard to find that on Slack, or do you have some form of "system" for tagging discussions in there?