Hacker News new | ask | show | jobs
by da39a3ee 1888 days ago
> The patch workflow is smooth a

Can you explain what a "patch workflow" is and in what sense Github is not a "patch workflow"?

There's some confusion since some people associate "patch workflow" with an email-based workflow.
1 comments
lima 1887 days ago
A patch/diff workflow operates at the level of individual diffs, rather than a branch identified by base and head refs like with pull requests.

Email is one (very clunky) way of implementing such a workflow, there's other tools like Gerrit, Reviewable or Phabricator that are more friendly.

link
da39a3ee 1887 days ago
Thanks. Can you explain why that might be a good thing?

If I update the diff, does it become a new reviewable item, independent from the first version?

I've never worked at a large tech company but my understanding is that at e.g. google there is some sort of monorepo, so it would presumably zoom forwards while a commit is under review. Even so, why is it not a good thing to review the commit in an explicit location in the historical commit graph?

link
lima 1887 days ago
Patches would still have a base, it's really more about about the data model. It's possible to synthesize a GitHub PR from a Gerrit CL and vice-versa.

In fact, Gerrit is entirely based on Git and you can simply clone any given CL.

link