Hacker News new | ask | show | jobs
by josegonzalez 5481 days ago
No it wasn't. As sc68cal says, its a patchbomb. And if you think otherwise, let me know how I can revert his changes to remove short tags and the mysql* changes using a single git command (hint, there isn't).

I'm all for changes to an open source project - whether it acts like one or not - but every open source developer should, at some point, learn that gigantic patchsets with lots of unrelated changes are a big no-no.
2 comments
sc68cal 5481 days ago
I'm just pissed that he didn't even bother to actually fork the project. On Github! WOW! All the previous commits before the fork? Gone. Poof. It's completely without any context. Even though there's a big "FORK" button!
link
mattyb 5481 days ago
Well what project would he fork? The (apparently) official PHP mirror is way out of date:

https://github.com/php/php-src

link
sc68cal 5481 days ago
Well, then just use git svn to update the master of his fork to match the official PHP svn. It'll just be a fast forward anyway.

Two birds with one stone.

link
xarg 5481 days ago
I work on it. I currently update the git repo with the svn sources. This is somewhat slow... May I ask what you want to do with the dissected patches? Try to build a "clean" version as pbiggar has said?
link
josegonzalez 5481 days ago
This doesn't concern me as much, so long as he has a note saying "compiled onto commit hash blah". Cherry-picking would be a pain, but doable at that point.
link
mattyb 5481 days ago
Well I wasn't sure what you meant by in a batch. I agree that it wasn't well done, but I wasn't commenting on that.

It's especially interesting considering he says this in the comments:

...I don't want to leave it as a stand alone project. I modified PHP as proof of concept in order to get these changes into one of the next releases.

link