[quasse]

As well as stripping comments, did they also strip and replace variable names? This code reminds me of trying to grok autogenerated Java GUI code in CS101.

[Avery3R]

Nah, it just looks like microsoft's usual hungarian notation https://docs.microsoft.com/en-us/windows/win32/stg/coding-st...

[dlod]

Yes, Hungarian was fresh in 1988 so naturally heavy use in this code base.

[mypalmike]

I haven't seen Hungarian notation in so long. It's so painful to look at. And yet back in the day I too was convinced it was a good idea.

[brettsh]

Confession: I still LOVE it. If I had a green field project today, I would still use it. Brett Shirley [MSFT] ESE Developer.

[mypalmike]

Yeah it wasn't until after I moved from C++ to other languages that I changed my mind on this (ESE appears to be primarily C++).

When you can 100% rely on your IDE to give you the metadata about a variable using color and/or hover pop-ups, storing that same metadata in the variable name just feels heavy and unnecessary. With C++ IDEs, you will never get 100% accuracy, so you might as well give in and go with Hungarian.

[vbezhenar]

    BOOL    fVisible;
    INT cbKey = 0;
    BOOKMARK        bmSearch;
    ULONG           cbReq;

I don't think so.