Hacker News new | ask | show | jobs
by microtherion 2024 days ago
I was going to say something similar.

When I'm the reviewer, I try to decided for myself whether something is truly important, or just a style choice. If it's the latter, I will comment on it, but then add "Your call." to make it clear that I expect ties to go to the author.

1 comments

This should be included in a "How to Make Your Code Reviewee Fall in Love with You" companion article, if one doesn't exist yet.
I wrote a list of code review suggestions a few years ago that focus on things the reviewer should do:

https://mtlynch.io/human-code-reviews-1/

I wrote a "what makes for a good change" doc a while ago, that touches on this.

https://github.com/vatine/sressays/blob/master/change-reques...