|
|
|
|
|
|
by booleandilemma
2101 days ago
|
|
|
...so nobody notice the mess your solutions are. They work. I’ve found what’s a mess and what’s not is often subjective. Oftentimes the comments a guy makes in a code review come down to whether he enjoyed his breakfast that morning. If your code solves the problem, it’s good enough. |
|
|
If your code is unintelligible, has no comments, cannot be maintained by anyone, has poor style, no tests, generic variable names, copy pasted code all over but solves the problem, it’s not good enough and should very much incur a code reviews with things to fix before it’s merged. That doesn’t depend on the reviewers mood either, it’s down to best practices and company standards.
I currently work at a place where “it solves the problem, ship it” is the norm. Codebases are 1–10 years old (depending on the project). It’s a living nightmare. No one knows how anything works, making trivial changes take weeks and will break something else, turnover is very high because life is too short to put up with such a low code quality and quality of life... I don’t recommend this approach of “if it solves the problem it’s good enough” unless you want to be unable to hire, kmrrtain your staff, and have a miserable work environment with constant fires everywhere.