[davesmylie]

A big issue I can foresee with this (other than confidentiality, etc) is simply the time required to give a quality review of a decent sized block of code, and making sure you get back a fair review in exchange.

You can review and give decent feedback on a small snippet of code fairly easily and quickly, but that's of limited value in a real project.

To be able to give a decent review (eg beyond a cursory "You should name that variable better, or your indentation sucks), requires that either the amount of code you are reviewing is so small that you can grok it quickly (limiting the value of the review), or that you spend at least some time familiarizing yourself with the rest of the code base so be able to gauge the impact of the code changes.

This is all good if the person you're trading reviews is prepared to spend the same amount of time on your code, but for example, I find it very frustrating when I spend 30-45 minutes giving a detailed review of a website on http://feedbackroulette.com (a similar concept, but for websites reviews), only to get back a 3 sentence review in exchange that was clearly bashed off in about 30 seconds. Awarding points for reviews goes someway to alleviate this, but still it's a real pita...