Hacker News new | ask | show | jobs
by koolba 2194 days ago
> https://github.com/VOTEism/server/blob/d8d3752af99d7f4c25c0b...

Why fork threads only to immediately join on them? This is just sync code with extra context switching and fatter stack traces.

> https://github.com/VOTEism/server/blob/d8d3752af99d7f4c25c0b...

This creates a new thread pool for each login request. That's a terrible idea. If anything create it once statically and re-use it. Or just perform your actions in the calling thread as you're just issuing a .get() on the future anyway. Again, it's needless complexity.

1 comments

Thanks for pointing the issue with the thread pool and will take a look.