Hacker News new | ask | show | jobs
by warpech 2244 days ago
In my team, we review PRs first thing in the morning the following day. It is for the benefit of everyone. People are less distracted and know that they can get occupied with other things by working at their own schedule until the end of the day.
1 comments

Yes, that's my daily routine. Sipping coffee and reviewing code. During the day I'm happy to re-review code if I asked for a modification because I only have to check a small part of the code and I'm already familiar with the whole concept.

Reviewing any non-trivial complexity code has a big task switch cost. Reviewing code during the day is bad for productivity.