|
|
|
|
|
by trashburger
2243 days ago
|
|
The problem is that if you are putting this out there for purposes of education, it should use best practices, and it clearly doesn't here. I suggest that you significantly refactor this code. I believe that it can become much better with more modularization, more clearly explaining some aspects of the code and better project structuring. |
|
There's a French saying that goes "C'est en forgeant qu'on devient forgeron" (it is by "black-smithing" that one becomes a black-smith).
One way to discover best practices is by putting things out in the open and receiving benevolent feedback on how to do it better.
The code will improve as the author reads more about best practices to apply on a real project they have shared with the comunity, and a benevolent comunity submitting issues and pull requests.
Here's the link to create an issue in that repo:
https://github.com/DirkJanJansen/Pandora/issues/new